Skip to content

Commit

Permalink
MD RAID10: Export md_raid10_congested
Browse files Browse the repository at this point in the history
md/raid10: Export is_congested test.

In similar fashion to commits
	11d8a6e
	1ed7242
we export the RAID10 congestion checking function so that dm-raid.c can
make use of it and make use of the personality.  The 'queue' and 'gendisk'
structures will not be available to the MD code when device-mapper sets
up the device, so we conditionalize access to these fields also.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
  • Loading branch information
Jonathan Brassow authored and NeilBrown committed Jul 31, 2012
1 parent 473e87c commit cc4d1ef
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 22 deletions.
56 changes: 34 additions & 22 deletions drivers/md/raid10.c
Original file line number Diff line number Diff line change
Expand Up @@ -853,18 +853,15 @@ static struct md_rdev *read_balance(struct r10conf *conf,
return rdev;
}

static int raid10_congested(void *data, int bits)
int md_raid10_congested(struct mddev *mddev, int bits)
{
struct mddev *mddev = data;
struct r10conf *conf = mddev->private;
int i, ret = 0;

if ((bits & (1 << BDI_async_congested)) &&
conf->pending_count >= max_queued_requests)
return 1;

if (mddev_congested(mddev, bits))
return 1;
rcu_read_lock();
for (i = 0;
(i < conf->geo.raid_disks || i < conf->prev.raid_disks)
Expand All @@ -880,6 +877,15 @@ static int raid10_congested(void *data, int bits)
rcu_read_unlock();
return ret;
}
EXPORT_SYMBOL_GPL(md_raid10_congested);

static int raid10_congested(void *data, int bits)
{
struct mddev *mddev = data;

return mddev_congested(mddev, bits) ||
md_raid10_congested(mddev, bits);
}

static void flush_pending_writes(struct r10conf *conf)
{
Expand Down Expand Up @@ -3486,12 +3492,14 @@ static int run(struct mddev *mddev)
conf->thread = NULL;

chunk_size = mddev->chunk_sectors << 9;
blk_queue_io_min(mddev->queue, chunk_size);
if (conf->geo.raid_disks % conf->geo.near_copies)
blk_queue_io_opt(mddev->queue, chunk_size * conf->geo.raid_disks);
else
blk_queue_io_opt(mddev->queue, chunk_size *
(conf->geo.raid_disks / conf->geo.near_copies));
if (mddev->queue) {
blk_queue_io_min(mddev->queue, chunk_size);
if (conf->geo.raid_disks % conf->geo.near_copies)
blk_queue_io_opt(mddev->queue, chunk_size * conf->geo.raid_disks);
else
blk_queue_io_opt(mddev->queue, chunk_size *
(conf->geo.raid_disks / conf->geo.near_copies));
}

rdev_for_each(rdev, mddev) {
long long diff;
Expand Down Expand Up @@ -3525,8 +3533,9 @@ static int run(struct mddev *mddev)
if (first || diff < min_offset_diff)
min_offset_diff = diff;

disk_stack_limits(mddev->gendisk, rdev->bdev,
rdev->data_offset << 9);
if (mddev->gendisk)
disk_stack_limits(mddev->gendisk, rdev->bdev,
rdev->data_offset << 9);

disk->head_position = 0;
}
Expand Down Expand Up @@ -3589,22 +3598,22 @@ static int run(struct mddev *mddev)
md_set_array_sectors(mddev, size);
mddev->resync_max_sectors = size;

mddev->queue->backing_dev_info.congested_fn = raid10_congested;
mddev->queue->backing_dev_info.congested_data = mddev;

/* Calculate max read-ahead size.
* We need to readahead at least twice a whole stripe....
* maybe...
*/
{
if (mddev->queue) {
int stripe = conf->geo.raid_disks *
((mddev->chunk_sectors << 9) / PAGE_SIZE);
mddev->queue->backing_dev_info.congested_fn = raid10_congested;
mddev->queue->backing_dev_info.congested_data = mddev;

/* Calculate max read-ahead size.
* We need to readahead at least twice a whole stripe....
* maybe...
*/
stripe /= conf->geo.near_copies;
if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe)
mddev->queue->backing_dev_info.ra_pages = 2 * stripe;
blk_queue_merge_bvec(mddev->queue, raid10_mergeable_bvec);
}

blk_queue_merge_bvec(mddev->queue, raid10_mergeable_bvec);

if (md_integrity_register(mddev))
goto out_free_conf;
Expand Down Expand Up @@ -3655,7 +3664,10 @@ static int stop(struct mddev *mddev)
lower_barrier(conf);

md_unregister_thread(&mddev->thread);
blk_sync_queue(mddev->queue); /* the unplug fn references 'conf'*/
if (mddev->queue)
/* the unplug fn references 'conf'*/
blk_sync_queue(mddev->queue);

if (conf->r10bio_pool)
mempool_destroy(conf->r10bio_pool);
kfree(conf->mirrors);
Expand Down
3 changes: 3 additions & 0 deletions drivers/md/raid10.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,7 @@ enum r10bio_state {
*/
R10BIO_Previous,
};

extern int md_raid10_congested(struct mddev *mddev, int bits);

#endif

0 comments on commit cc4d1ef

Please sign in to comment.