Skip to content

Commit

Permalink
s390/ctl_reg: move control register definitions to ctl_reg.h
Browse files Browse the repository at this point in the history
The nmi.h header has some constant defines for control register bits.
These definitions should really be located in ctl_reg.h. Move and
rename the defines.

Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Martin Schwidefsky committed Oct 19, 2017
1 parent ad3bc0a commit cc65450
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
11 changes: 11 additions & 0 deletions arch/s390/include/asm/ctl_reg.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@
#ifndef __ASM_CTL_REG_H
#define __ASM_CTL_REG_H

#include <linux/const.h>

#define CR14_CHANNEL_REPORT_SUBMASK _BITUL(63 - 35)
#define CR14_RECOVERY_SUBMASK _BITUL(63 - 36)
#define CR14_DEGRADATION_SUBMASK _BITUL(63 - 37)
#define CR14_EXTERNAL_DAMAGE_SUBMASK _BITUL(63 - 38)
#define CR14_WARNING_SUBMASK _BITUL(63 - 39)

#ifndef __ASSEMBLY__

#include <linux/bug.h>

#define __ctl_load(array, low, high) do { \
Expand Down Expand Up @@ -95,4 +105,5 @@ union ctlreg2 {
# define ctl_clear_bit(cr, bit) __ctl_clear_bit(cr, bit)
#endif

#endif /* __ASSEMBLY__ */
#endif /* __ASM_CTL_REG_H */
6 changes: 0 additions & 6 deletions arch/s390/include/asm/nmi.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@
#define MCCK_CODE_PSW_MWP_VALID _BITUL(63 - 20)
#define MCCK_CODE_PSW_IA_VALID _BITUL(63 - 23)

#define MCCK_CR14_CR_PENDING_SUB_MASK (1 << 28)
#define MCCK_CR14_RECOVERY_SUB_MASK (1 << 27)
#define MCCK_CR14_DEGRAD_SUB_MASK (1 << 26)
#define MCCK_CR14_EXT_DAMAGE_SUB_MASK (1 << 25)
#define MCCK_CR14_WARN_SUB_MASK (1 << 24)

#ifndef __ASSEMBLY__

union mci {
Expand Down
6 changes: 3 additions & 3 deletions arch/s390/kvm/interrupt.c
Original file line number Diff line number Diff line change
Expand Up @@ -2483,11 +2483,11 @@ void kvm_s390_reinject_machine_check(struct kvm_vcpu *vcpu,

mci.val = mcck_info->mcic;
if (mci.sr)
cr14 |= MCCK_CR14_RECOVERY_SUB_MASK;
cr14 |= CR14_RECOVERY_SUBMASK;
if (mci.dg)
cr14 |= MCCK_CR14_DEGRAD_SUB_MASK;
cr14 |= CR14_DEGRADATION_SUBMASK;
if (mci.w)
cr14 |= MCCK_CR14_WARN_SUB_MASK;
cr14 |= CR14_WARNING_SUBMASK;

mchk = mci.ck ? &inti.mchk : &irq.u.mchk;
mchk->cr14 = cr14;
Expand Down

0 comments on commit cc65450

Please sign in to comment.