Skip to content

Commit

Permalink
drm/radeon: update IB size estimation for VM
Browse files Browse the repository at this point in the history
That should allow us to allocate bigger BOs.

Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Christian König authored and Alex Deucher committed Aug 5, 2014
1 parent 03f62ab commit cc6f353
Showing 1 changed file with 30 additions and 13 deletions.
43 changes: 30 additions & 13 deletions drivers/gpu/drm/radeon/radeon_vm.c
Original file line number Diff line number Diff line change
Expand Up @@ -410,15 +410,15 @@ static int radeon_vm_clear_bo(struct radeon_device *rdev,
addr = radeon_bo_gpu_offset(bo);
entries = radeon_bo_size(bo) / 8;

r = radeon_ib_get(rdev, R600_RING_TYPE_DMA_INDEX, &ib,
NULL, entries * 2 + 64);
r = radeon_ib_get(rdev, R600_RING_TYPE_DMA_INDEX, &ib, NULL, 256);
if (r)
goto error;

ib.length_dw = 0;

radeon_vm_set_pages(rdev, &ib, addr, 0, entries, 0, 0);
radeon_asic_vm_pad_ib(rdev, &ib);
WARN_ON(ib.length_dw > 64);

r = radeon_ib_schedule(rdev, &ib, NULL);
if (r)
Expand Down Expand Up @@ -642,7 +642,7 @@ int radeon_vm_update_page_directory(struct radeon_device *rdev,
ndw = 64;

/* assume the worst case */
ndw += vm->max_pde_used * 16;
ndw += vm->max_pde_used * 6;

/* update too big for an IB */
if (ndw > 0xfffff)
Expand Down Expand Up @@ -692,6 +692,7 @@ int radeon_vm_update_page_directory(struct radeon_device *rdev,
radeon_asic_vm_pad_ib(rdev, &ib);
radeon_semaphore_sync_to(ib.semaphore, pd->tbo.sync_obj);
radeon_semaphore_sync_to(ib.semaphore, vm->last_id_use);
WARN_ON(ib.length_dw > ndw);
r = radeon_ib_schedule(rdev, &ib, NULL);
if (r) {
radeon_ib_free(rdev, &ib);
Expand Down Expand Up @@ -871,8 +872,9 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
{
struct radeon_vm *vm = bo_va->vm;
struct radeon_ib ib;
unsigned nptes, ndw;
unsigned nptes, ncmds, ndw;
uint64_t addr;
uint32_t flags;
int r;

if (!bo_va->it.start) {
Expand Down Expand Up @@ -911,19 +913,32 @@ int radeon_vm_bo_update(struct radeon_device *rdev,

nptes = bo_va->it.last - bo_va->it.start + 1;

/* reserve space for one command every (1 << BLOCK_SIZE) entries
or 2k dwords (whatever is smaller) */
ncmds = (nptes >> min(radeon_vm_block_size, 11)) + 1;

/* padding, etc. */
ndw = 64;

if (radeon_vm_block_size > 11)
/* reserve space for one header for every 2k dwords */
ndw += (nptes >> 11) * 4;
else
/* reserve space for one header for
every (1 << BLOCK_SIZE) entries */
ndw += (nptes >> radeon_vm_block_size) * 4;
flags = radeon_vm_page_flags(bo_va->flags);
if ((flags & R600_PTE_GART_MASK) == R600_PTE_GART_MASK) {
/* only copy commands needed */
ndw += ncmds * 7;

} else if (flags & R600_PTE_SYSTEM) {
/* header for write data commands */
ndw += ncmds * 4;

/* body of write data command */
ndw += nptes * 2;

/* reserve space for pte addresses */
ndw += nptes * 2;
} else {
/* set page commands needed */
ndw += ncmds * 10;

/* two extra commands for begin/end of fragment */
ndw += 2 * 10;
}

/* update too big for an IB */
if (ndw > 0xfffff)
Expand All @@ -939,6 +954,8 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
radeon_vm_page_flags(bo_va->flags));

radeon_asic_vm_pad_ib(rdev, &ib);
WARN_ON(ib.length_dw > ndw);

radeon_semaphore_sync_to(ib.semaphore, vm->fence);
r = radeon_ib_schedule(rdev, &ib, NULL);
if (r) {
Expand Down

0 comments on commit cc6f353

Please sign in to comment.