Skip to content

Commit

Permalink
ibmvnic: Wait until reset is complete to set carrier on
Browse files Browse the repository at this point in the history
Pushes back setting the carrier on until the end of the reset
code. This resolves a bug where a watchdog timer was detecting
that a TX queue had stalled before the adapter reset was complete.

Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Thomas Falcon authored and David S. Miller committed Feb 14, 2018
1 parent e6dbe93 commit cc85c02
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/ibm/ibmvnic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1670,15 +1670,15 @@ static int do_reset(struct ibmvnic_adapter *adapter,
return 0;
}

netif_carrier_on(netdev);

/* kick napi */
for (i = 0; i < adapter->req_rx_queues; i++)
napi_schedule(&adapter->napi[i]);

if (adapter->reset_reason != VNIC_RESET_FAILOVER)
netdev_notify_peers(netdev);

netif_carrier_on(netdev);

return 0;
}

Expand Down

0 comments on commit cc85c02

Please sign in to comment.