Skip to content

Commit

Permalink
net: tcp_probe: adapt tbuf size for recent changes
Browse files Browse the repository at this point in the history
With recent changes in tcp_probe module (e.g. f925d0a ("net: tcp_probe:
add IPv6 support")) we also need to take into account that tbuf needs to
be updated as format string will be further expanded. tbuf sits on the stack
in tcpprobe_read() function that is invoked when user space reads procfs
file /proc/net/tcpprobe, hence not fast path as in jtcp_rcv_established().
Having a size similarly as in sctp_probe module of 256 bytes is fully
sufficient for that, we need theoretical maximum of 252 bytes otherwise we
could get truncated.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Daniel Borkmann authored and David S. Miller committed Sep 4, 2013
1 parent 3cc4a67 commit cc8c6c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/tcp_probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ static ssize_t tcpprobe_read(struct file *file, char __user *buf,
return -EINVAL;

while (cnt < len) {
char tbuf[164];
char tbuf[256];
int width;

/* Wait for data in buffer */
Expand Down

0 comments on commit cc8c6c1

Please sign in to comment.