Skip to content

Commit

Permalink
can: kvaser_usb: kvaser_usb_set_bittiming(): fix redundant initializa…
Browse files Browse the repository at this point in the history
…tion warning for err

The variable err is initialized, but the initialized value is
Overwritten before it is read. Fix the warning by not initializing the
variable err at all.

Fixes: 39d3df6 ("can: kvaser_usb: Compare requested bittiming parameters with actual parameters in do_set_{,data}_bittiming")
Cc: Jimmy Assarsson <extja@kvaser.com>
Cc: Anssi Hannula <anssi.hannula@bitwise.fi>
Link: https://lore.kernel.org/all/20221031114513.81214-1-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Dec 10, 2022
1 parent dd8b3a8 commit cce2d7d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ static int kvaser_usb_set_bittiming(struct net_device *netdev)
int tseg1 = bt->prop_seg + bt->phase_seg1;
int tseg2 = bt->phase_seg2;
int sjw = bt->sjw;
int err = -EOPNOTSUPP;
int err;

busparams.bitrate = cpu_to_le32(bt->bitrate);
busparams.sjw = (u8)sjw;
Expand Down

0 comments on commit cce2d7d

Please sign in to comment.