Skip to content

Commit

Permalink
io_uring: fix poll file assign deadlock
Browse files Browse the repository at this point in the history
We pass "unlocked" into io_assign_file() in io_poll_check_events(),
which can lead to double locking.

Fixes: 6bf9c47 ("io_uring: defer file assignment")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/2476d4ae46554324b599ee4055447b105f20a75a.1649862516.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Pavel Begunkov authored and Jens Axboe committed Apr 13, 2022
1 parent e941976 commit cce64ef
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/io_uring.c
Original file line number Diff line number Diff line change
Expand Up @@ -5858,8 +5858,9 @@ static int io_poll_check_events(struct io_kiocb *req, bool locked)

if (!req->result) {
struct poll_table_struct pt = { ._key = req->apoll_events };
unsigned flags = locked ? 0 : IO_URING_F_UNLOCKED;

if (unlikely(!io_assign_file(req, IO_URING_F_UNLOCKED)))
if (unlikely(!io_assign_file(req, flags)))
req->result = -EBADF;
else
req->result = vfs_poll(req->file, &pt) & req->apoll_events;
Expand Down

0 comments on commit cce64ef

Please sign in to comment.