Skip to content

Commit

Permalink
net: emaclite: Report failures in mdio setup
Browse files Browse the repository at this point in the history
Be more verbose when any problem happens.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Michal Simek authored and David S. Miller committed May 31, 2013
1 parent cafe890 commit ccfecdf
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions drivers/net/ethernet/xilinx/xilinx_emaclite.c
Original file line number Diff line number Diff line change
Expand Up @@ -852,8 +852,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
/* Don't register the MDIO bus if the phy_node or its parent node
* can't be found.
*/
if (!np)
if (!np) {
dev_err(dev, "Failed to register mdio bus.\n");
return -ENODEV;
}

/* Enable the MDIO bus by asserting the enable bit in MDIO Control
* register.
Expand All @@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
XEL_MDIOCTRL_MDIOEN_MASK);

bus = mdiobus_alloc();
if (!bus)
if (!bus) {
dev_err(dev, "Failed to allocal mdiobus\n");
return -ENOMEM;
}

of_address_to_resource(np, 0, &res);
snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx",
Expand All @@ -879,8 +883,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
lp->mii_bus = bus;

rc = of_mdiobus_register(bus, np);
if (rc)
if (rc) {
dev_err(dev, "Failed to register mdio bus.\n");
goto err_register;
}

return 0;

Expand Down

0 comments on commit ccfecdf

Please sign in to comment.