Skip to content

Commit

Permalink
thp: cleanup how khugepaged enters freezer
Browse files Browse the repository at this point in the history
khugepaged_do_scan() checks in every iteration whether freezing(current)
is true, and in such case breaks out of the loop, which causes
try_to_freeze() to be called immediately afterwards in
khugepaged_wait_work().

If nothing else, this causes unnecessary freezing(current) test, and also
makes the way khugepaged enters freezer a bit less obvious than necessary.

Let's just try to freeze directly, instead of splitting it into two
(directly adjacent) phases.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Kosina authored and Linus Torvalds committed Jun 25, 2015
1 parent ebb0973 commit cd09241
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions mm/huge_memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -2799,7 +2799,7 @@ static void khugepaged_do_scan(void)

cond_resched();

if (unlikely(kthread_should_stop() || freezing(current)))
if (unlikely(kthread_should_stop() || try_to_freeze()))
break;

spin_lock(&khugepaged_mm_lock);
Expand All @@ -2820,8 +2820,6 @@ static void khugepaged_do_scan(void)

static void khugepaged_wait_work(void)
{
try_to_freeze();

if (khugepaged_has_work()) {
if (!khugepaged_scan_sleep_millisecs)
return;
Expand Down

0 comments on commit cd09241

Please sign in to comment.