Skip to content

Commit

Permalink
usb: chipidea: put hw_phymode_configure before ci_usb_phy_init
Browse files Browse the repository at this point in the history
hw_phymode_configure configures the PORTSC registers and allow the
following phy_inits to operate on the right parameters. This fix a problem
where the UPLI (ISP1504) could not be detected, because the Viewport was not
available and read the viewport return 0's only.

Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Chris Ruehl authored and Greg Kroah-Hartman committed Jan 13, 2014
1 parent 3b5d3e6 commit cd0b42c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/chipidea/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,8 @@ static int ci_hdrc_probe(struct platform_device *pdev)
return -ENODEV;
}

hw_phymode_configure(ci);

ret = ci_usb_phy_init(ci);
if (ret) {
dev_err(dev, "unable to init phy: %d\n", ret);
Expand All @@ -576,8 +578,6 @@ static int ci_hdrc_probe(struct platform_device *pdev)

ci_get_otg_capable(ci);

hw_phymode_configure(ci);

dr_mode = ci->platdata->dr_mode;
/* initialize role(s) before the interrupt is requested */
if (dr_mode == USB_DR_MODE_OTG || dr_mode == USB_DR_MODE_HOST) {
Expand Down

0 comments on commit cd0b42c

Please sign in to comment.