Skip to content

Commit

Permalink
ipmi: kcs_bmc: don't change device name
Browse files Browse the repository at this point in the history
kcs_bmc_alloc(...) calls dev_set_name(...) which is incorrect as most
bus driver frameworks, platform_driver in particular, assume that they
are able to set the device name themselves.

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
  • Loading branch information
Benjamin Fair authored and Corey Minyard committed Aug 30, 2018
1 parent 9f8f16c commit cd2315d
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/char/ipmi/kcs_bmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include "kcs_bmc.h"

#define DEVICE_NAME "ipmi-kcs"

#define KCS_MSG_BUFSIZ 1000

#define KCS_ZERO_DATA 0
Expand Down Expand Up @@ -429,8 +431,6 @@ struct kcs_bmc *kcs_bmc_alloc(struct device *dev, int sizeof_priv, u32 channel)
if (!kcs_bmc)
return NULL;

dev_set_name(dev, "ipmi-kcs%u", channel);

spin_lock_init(&kcs_bmc->lock);
kcs_bmc->channel = channel;

Expand All @@ -444,7 +444,8 @@ struct kcs_bmc *kcs_bmc_alloc(struct device *dev, int sizeof_priv, u32 channel)
return NULL;

kcs_bmc->miscdev.minor = MISC_DYNAMIC_MINOR;
kcs_bmc->miscdev.name = dev_name(dev);
kcs_bmc->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%u",
DEVICE_NAME, channel);
kcs_bmc->miscdev.fops = &kcs_bmc_fops;

return kcs_bmc;
Expand Down

0 comments on commit cd2315d

Please sign in to comment.