Skip to content

Commit

Permalink
spi: orion: Let spi core handle validating transfer length
Browse files Browse the repository at this point in the history
spi core will handle validating transfer length since commit 4d94bd2
"spi: core: Validate length of the transfers in message".
So remove the same checking in this driver.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Axel Lin authored and Mark Brown committed Mar 1, 2014
1 parent 495b335 commit cd2ac0c
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions drivers/spi/spi-orion.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,17 +296,6 @@ static int orion_spi_transfer_one_message(struct spi_master *master,
goto msg_done;

list_for_each_entry(t, &m->transfers, transfer_list) {
/* make sure buffer length is even when working in 16
* bit mode*/
if ((t->bits_per_word == 16) && (t->len & 1)) {
dev_err(&spi->dev,
"message rejected : "
"odd data length %d while in 16 bit mode\n",
t->len);
status = -EIO;
goto msg_done;
}

if (par_override || t->speed_hz || t->bits_per_word) {
par_override = 1;
status = orion_spi_setup_transfer(spi, t);
Expand Down

0 comments on commit cd2ac0c

Please sign in to comment.