Skip to content

Commit

Permalink
block: Expose stacked device queues in sysfs
Browse files Browse the repository at this point in the history
Currently stacking devices do not have a queue directory in sysfs.
However, many of the I/O characteristics like sector size, maximum
request size, etc. are queue properties.

This patch enables the queue directory for MD/DM devices.  The elevator
code has been modified to deal with queues that do not have an I/O
scheduler.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Martin K. Petersen authored and Jens Axboe committed May 22, 2009
1 parent 025146e commit cd43e26
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
6 changes: 3 additions & 3 deletions block/blk-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,16 +395,16 @@ int blk_register_queue(struct gendisk *disk)
if (WARN_ON(!q))
return -ENXIO;

if (!q->request_fn)
return 0;

ret = kobject_add(&q->kobj, kobject_get(&disk_to_dev(disk)->kobj),
"%s", "queue");
if (ret < 0)
return ret;

kobject_uevent(&q->kobj, KOBJ_ADD);

if (!q->request_fn)
return 0;

ret = elv_register_queue(q);
if (ret) {
kobject_uevent(&q->kobj, KOBJ_REMOVE);
Expand Down
13 changes: 12 additions & 1 deletion block/elevator.c
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,9 @@ void elv_drain_elevator(struct request_queue *q)
*/
void elv_quiesce_start(struct request_queue *q)
{
if (!q->elevator)
return;

queue_flag_set(QUEUE_FLAG_ELVSWITCH, q);

/*
Expand Down Expand Up @@ -1050,6 +1053,9 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
char elevator_name[ELV_NAME_MAX];
struct elevator_type *e;

if (!q->elevator)
return count;

strlcpy(elevator_name, name, sizeof(elevator_name));
strstrip(elevator_name);

Expand All @@ -1073,10 +1079,15 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
ssize_t elv_iosched_show(struct request_queue *q, char *name)
{
struct elevator_queue *e = q->elevator;
struct elevator_type *elv = e->elevator_type;
struct elevator_type *elv;
struct elevator_type *__e;
int len = 0;

if (!q->elevator)
return sprintf(name, "none\n");

elv = e->elevator_type;

spin_lock(&elv_list_lock);
list_for_each_entry(__e, &elv_list, list) {
if (!strcmp(elv->elevator_name, __e->elevator_name))
Expand Down

0 comments on commit cd43e26

Please sign in to comment.