Skip to content

Commit

Permalink
KVM: arm/arm64: Move phys_timer_emulate function
Browse files Browse the repository at this point in the history
We are about to call phys_timer_emulate() from kvm_timer_update_state()
and modify phys_timer_emulate() at the same time.  Moving the function
and modifying it in a single patch makes the diff hard to read, so do
this separately first.

No functional change.

Signed-off-by: Christoffer Dall <cdall@linaro.org>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
  • Loading branch information
Christoffer Dall authored and Christoffer Dall committed Nov 6, 2017
1 parent c1b135a commit cda93b7
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions virt/kvm/arm/arch_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,22 @@ static void kvm_timer_update_irq(struct kvm_vcpu *vcpu, bool new_level,
}
}

/* Schedule the background timer for the emulated timer. */
static void phys_timer_emulate(struct kvm_vcpu *vcpu,
struct arch_timer_context *timer_ctx)
{
struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu;

if (kvm_timer_should_fire(timer_ctx))
return;

if (!kvm_timer_irq_can_fire(timer_ctx))
return;

/* The timer has not yet expired, schedule a background timer */
soft_timer_start(&timer->phys_timer, kvm_timer_compute_delta(timer_ctx));
}

/*
* Check if there was a change in the timer state (should we raise or lower
* the line level to the GIC).
Expand All @@ -281,22 +297,6 @@ static void kvm_timer_update_state(struct kvm_vcpu *vcpu)
kvm_timer_update_irq(vcpu, !ptimer->irq.level, ptimer);
}

/* Schedule the background timer for the emulated timer. */
static void phys_timer_emulate(struct kvm_vcpu *vcpu,
struct arch_timer_context *timer_ctx)
{
struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu;

if (kvm_timer_should_fire(timer_ctx))
return;

if (!kvm_timer_irq_can_fire(timer_ctx))
return;

/* The timer has not yet expired, schedule a background timer */
soft_timer_start(&timer->phys_timer, kvm_timer_compute_delta(timer_ctx));
}

static void vtimer_save_state(struct kvm_vcpu *vcpu)
{
struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu;
Expand Down

0 comments on commit cda93b7

Please sign in to comment.