Skip to content

Commit

Permalink
netfilter: uapi: fix linux/netfilter/nf_osf.h userspace compilation e…
Browse files Browse the repository at this point in the history
…rrors

Move inclusion of <linux/ip.h> and <linux/tcp.h> from
linux/netfilter/xt_osf.h to linux/netfilter/nf_osf.h to fix
the following linux/netfilter/nf_osf.h userspace compilation errors:

/usr/include/linux/netfilter/nf_osf.h:59:24: error: 'MAX_IPOPTLEN' undeclared here (not in a function)
  struct nf_osf_opt opt[MAX_IPOPTLEN];
/usr/include/linux/netfilter/nf_osf.h:64:17: error: field 'ip' has incomplete type
  struct iphdr   ip;
/usr/include/linux/netfilter/nf_osf.h:65:18: error: field 'tcp' has incomplete type
  struct tcphdr   tcp;

Fixes: bfb15f2 ("netfilter: extract Passive OS fingerprint infrastructure from xt_osf")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Dmitry V. Levin authored and Pablo Neira Ayuso committed Aug 16, 2018
1 parent 3206c51 commit cdb2f40
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions include/uapi/linux/netfilter/nfnetlink_osf.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
#define _NF_OSF_H

#include <linux/types.h>
#include <linux/ip.h>
#include <linux/tcp.h>

#define MAXGENRELEN 32

Expand Down
2 changes: 0 additions & 2 deletions include/uapi/linux/netfilter/xt_osf.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
#define _XT_OSF_H

#include <linux/types.h>
#include <linux/ip.h>
#include <linux/tcp.h>
#include <linux/netfilter/nfnetlink_osf.h>

#define XT_OSF_GENRE NF_OSF_GENRE
Expand Down

0 comments on commit cdb2f40

Please sign in to comment.