Skip to content

Commit

Permalink
ima: use generic_file_llseek for securityfs
Browse files Browse the repository at this point in the history
The default for llseek will change to no_llseek,
so securityfs users need to add explicit .llseek
assignments. Since we're dealing with regular
files from a VFS perspective, use generic_file_llseek.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Mimi Zohar <zohar@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
  • Loading branch information
Arnd Bergmann authored and James Morris committed Aug 2, 2010
1 parent 7e2deb7 commit cdcd90f
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions security/integrity/ima/ima_fs.c
Original file line number Diff line number Diff line change
@@ -45,7 +45,8 @@ static ssize_t ima_show_htable_violations(struct file *filp,
}

static const struct file_operations ima_htable_violations_ops = {
.read = ima_show_htable_violations
.read = ima_show_htable_violations,
.llseek = generic_file_llseek,
};

static ssize_t ima_show_measurements_count(struct file *filp,
@@ -57,7 +58,8 @@ static ssize_t ima_show_measurements_count(struct file *filp,
}

static const struct file_operations ima_measurements_count_ops = {
.read = ima_show_measurements_count
.read = ima_show_measurements_count,
.llseek = generic_file_llseek,
};

/* returns pointer to hlist_node */
@@ -319,7 +321,8 @@ static int ima_release_policy(struct inode *inode, struct file *file)
static const struct file_operations ima_measure_policy_ops = {
.open = ima_open_policy,
.write = ima_write_policy,
.release = ima_release_policy
.release = ima_release_policy,
.llseek = generic_file_llseek,
};

int __init ima_fs_init(void)

0 comments on commit cdcd90f

Please sign in to comment.