Skip to content

Commit

Permalink
[PATCH] knfsd: SUNRPC: Support IPv6 addresses in svc_tcp_accept
Browse files Browse the repository at this point in the history
Modify svc_tcp_accept to support connecting on IPv6 sockets.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: Aurelien Charbon <aurelien.charbon@ext.bull.net>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
akpm@linux-foundation.org authored and Linus Torvalds committed Feb 12, 2007
1 parent bcdb81a commit cdd88b9
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions net/sunrpc/svcsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,8 @@ static inline int svc_port_is_privileged(struct sockaddr *sin)
static void
svc_tcp_accept(struct svc_sock *svsk)
{
struct sockaddr_in sin;
struct sockaddr_storage addr;
struct sockaddr *sin = (struct sockaddr *) &addr;
struct svc_serv *serv = svsk->sk_server;
struct socket *sock = svsk->sk_sock;
struct socket *newsock;
Expand All @@ -987,8 +988,7 @@ svc_tcp_accept(struct svc_sock *svsk)
set_bit(SK_CONN, &svsk->sk_flags);
svc_sock_enqueue(svsk);

slen = sizeof(sin);
err = kernel_getpeername(newsock, (struct sockaddr *) &sin, &slen);
err = kernel_getpeername(newsock, sin, &slen);
if (err < 0) {
if (net_ratelimit())
printk(KERN_WARNING "%s: peername failed (err %d)!\n",
Expand All @@ -1000,16 +1000,14 @@ svc_tcp_accept(struct svc_sock *svsk)
* hosts here, but when we get encryption, the IP of the host won't
* tell us anything. For now just warn about unpriv connections.
*/
if (!svc_port_is_privileged((struct sockaddr *) &sin)) {
if (!svc_port_is_privileged(sin)) {
dprintk(KERN_WARNING
"%s: connect from unprivileged port: %s\n",
serv->sv_name,
__svc_print_addr((struct sockaddr *) &sin, buf,
sizeof(buf)));
__svc_print_addr(sin, buf, sizeof(buf)));
}
dprintk("%s: connect from %s\n", serv->sv_name,
__svc_print_addr((struct sockaddr *) &sin, buf,
sizeof(buf)));
__svc_print_addr(sin, buf, sizeof(buf)));

/* make sure that a write doesn't block forever when
* low on memory
Expand All @@ -1019,7 +1017,7 @@ svc_tcp_accept(struct svc_sock *svsk)
if (!(newsvsk = svc_setup_socket(serv, newsock, &err,
(SVC_SOCK_ANONYMOUS | SVC_SOCK_TEMPORARY))))
goto failed;
memcpy(&newsvsk->sk_remote, &sin, slen);
memcpy(&newsvsk->sk_remote, sin, slen);
newsvsk->sk_remotelen = slen;

svc_sock_received(newsvsk);
Expand Down

0 comments on commit cdd88b9

Please sign in to comment.