Skip to content

Commit

Permalink
watchdog: pic32-wdt: Fix return value check in pic32_wdt_drv_probe()
Browse files Browse the repository at this point in the history
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
  • Loading branch information
Wei Yongjun authored and Wim Van Sebroeck committed Jul 25, 2016
1 parent 919edd5 commit cddd74d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/watchdog/pic32-wdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ static int pic32_wdt_drv_probe(struct platform_device *pdev)
return PTR_ERR(wdt->regs);

wdt->rst_base = devm_ioremap(&pdev->dev, PIC32_BASE_RESET, 0x10);
if (IS_ERR(wdt->rst_base))
return PTR_ERR(wdt->rst_base);
if (!wdt->rst_base)
return -ENOMEM;

wdt->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(wdt->clk)) {
Expand Down

0 comments on commit cddd74d

Please sign in to comment.