Skip to content

Commit

Permalink
Merge git://git.kvack.org/~bcrl/aio-fixes
Browse files Browse the repository at this point in the history
Pull aio nested sleep annotation from Ben LaHaise,

* git://git.kvack.org/~bcrl/aio-fixes:
  aio: annotate aio_read_event_ring for sleep patterns
  • Loading branch information
Linus Torvalds committed Feb 9, 2015
2 parents 4e02370 + 9c9ce76 commit cdecbb3
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions fs/aio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,13 @@ static long aio_read_events_ring(struct kioctx *ctx,
long ret = 0;
int copy_ret;

/*
* The mutex can block and wake us up and that will cause
* wait_event_interruptible_hrtimeout() to schedule without sleeping
* and repeat. This should be rare enough that it doesn't cause
* peformance issues. See the comment in read_events() for more detail.
*/
sched_annotate_sleep();
mutex_lock(&ctx->ring_lock);

/* Access to ->ring_pages here is protected by ctx->ring_lock. */
Expand Down

0 comments on commit cdecbb3

Please sign in to comment.