Skip to content

Commit

Permalink
regcache: flat: Introduce register strider order
Browse files Browse the repository at this point in the history
Here we introduce regcache_flat_get_index(), which using register
stride order and bit rotation, will save some memory spaces for
flat cache. Though this will also lost some access performance,
since the bit rotation is used to get the index of the cache array,
and this could be ingored for memory I/O accessing.

Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Xiubo Li authored and Mark Brown committed Feb 19, 2016
1 parent 8b31ec5 commit ce11020
Showing 1 changed file with 15 additions and 5 deletions.
20 changes: 15 additions & 5 deletions drivers/base/regmap/regcache-flat.c
Original file line number Diff line number Diff line change
@@ -16,20 +16,30 @@

#include "internal.h"

static inline unsigned int regcache_flat_get_index(const struct regmap *map,
unsigned int reg)
{
return regcache_get_index_by_order(map, reg);
}

static int regcache_flat_init(struct regmap *map)
{
int i;
unsigned int *cache;

map->cache = kcalloc(map->max_register + 1, sizeof(unsigned int),
GFP_KERNEL);
if (!map || map->reg_stride_order < 0)
return -EINVAL;

map->cache = kcalloc(regcache_flat_get_index(map, map->max_register)
+ 1, sizeof(unsigned int), GFP_KERNEL);
if (!map->cache)
return -ENOMEM;

cache = map->cache;

for (i = 0; i < map->num_reg_defaults; i++)
cache[map->reg_defaults[i].reg] = map->reg_defaults[i].def;
cache[regcache_flat_get_index(map, map->reg_defaults[i].reg)] =
map->reg_defaults[i].def;

return 0;
}
@@ -47,7 +57,7 @@ static int regcache_flat_read(struct regmap *map,
{
unsigned int *cache = map->cache;

*value = cache[reg];
*value = cache[regcache_flat_get_index(map, reg)];

return 0;
}
@@ -57,7 +67,7 @@ static int regcache_flat_write(struct regmap *map, unsigned int reg,
{
unsigned int *cache = map->cache;

cache[reg] = value;
cache[regcache_flat_get_index(map, reg)] = value;

return 0;
}

0 comments on commit ce11020

Please sign in to comment.