Skip to content

Commit

Permalink
drm/tests: Add back seed value information
Browse files Browse the repository at this point in the history
As reported by Michał, the drm_mm and drm_buddy unit tests lost the
printk with seed value after they were refactored into KUnit.

Add kunit_info with seed value information to assure reproducibility.

Reported-by: Michał Winiarski <michal.winiarski@intel.com>
Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
Signed-off-by: Maíra Canal <mairacanal@riseup.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20221028221755.340487-1-arthurgrillo@riseup.net
  • Loading branch information
Arthur Grillo authored and Maíra Canal committed Nov 2, 2022
1 parent 444bbba commit ce28ab1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
6 changes: 4 additions & 2 deletions drivers/gpu/drm/tests/drm_buddy_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -726,11 +726,13 @@ static void drm_test_buddy_alloc_limit(struct kunit *test)
drm_buddy_fini(&mm);
}

static int drm_buddy_init_test(struct kunit *test)
static int drm_buddy_suite_init(struct kunit_suite *suite)
{
while (!random_seed)
random_seed = get_random_u32();

kunit_info(suite, "Testing DRM buddy manager, with random_seed=0x%x\n", random_seed);

return 0;
}

Expand All @@ -746,7 +748,7 @@ static struct kunit_case drm_buddy_tests[] = {

static struct kunit_suite drm_buddy_test_suite = {
.name = "drm_buddy",
.init = drm_buddy_init_test,
.suite_init = drm_buddy_suite_init,
.test_cases = drm_buddy_tests,
};

Expand Down
8 changes: 6 additions & 2 deletions drivers/gpu/drm/tests/drm_mm_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -2209,11 +2209,15 @@ static void drm_test_mm_color_evict_range(struct kunit *test)
vfree(nodes);
}

static int drm_mm_init_test(struct kunit *test)
static int drm_mm_suite_init(struct kunit_suite *suite)
{
while (!random_seed)
random_seed = get_random_u32();

kunit_info(suite,
"Testing DRM range manager, with random_seed=0x%x max_iterations=%u max_prime=%u\n",
random_seed, max_iterations, max_prime);

return 0;
}

Expand Down Expand Up @@ -2246,7 +2250,7 @@ static struct kunit_case drm_mm_tests[] = {

static struct kunit_suite drm_mm_test_suite = {
.name = "drm_mm",
.init = drm_mm_init_test,
.suite_init = drm_mm_suite_init,
.test_cases = drm_mm_tests,
};

Expand Down

0 comments on commit ce28ab1

Please sign in to comment.