Skip to content

Commit

Permalink
drm/nouveau/mxm: pretend to succeed, even if we can't shadow the MXM-SIS
Browse files Browse the repository at this point in the history
There's at least one known case where our shadowing code is buggy, and we
fail init.  Until we can be confident we're doing all this correctly, lets
succeed and risk crazy bios tables rather than failing for perfectly valid
configs too.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
  • Loading branch information
Ben Skeggs committed Feb 1, 2012
1 parent 7df898b commit ce2e789
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions drivers/gpu/drm/nouveau/nouveau_mxm.c
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,16 @@ nouveau_mxm_init(struct drm_device *dev)

if (mxm_shadow(dev, mxm[0])) {
MXM_MSG(dev, "failed to locate valid SIS\n");
#if 0
/* we should, perhaps, fall back to some kind of limited
* mode here if the x86 vbios hasn't already done the
* work for us (so we prevent loading with completely
* whacked vbios tables).
*/
return -EINVAL;
#else
return 0;
#endif
}

MXM_MSG(dev, "MXMS Version %d.%d\n",
Expand Down

0 comments on commit ce2e789

Please sign in to comment.