Skip to content

Commit

Permalink
net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe()
Browse files Browse the repository at this point in the history
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Jul 14, 2016
1 parent 3f30849 commit ce3a380
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/net/ethernet/broadcom/bgmac-platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,8 @@ static int bgmac_probe(struct platform_device *pdev)
}

bgmac->plat.base = devm_ioremap_resource(&pdev->dev, regs);
if (IS_ERR(bgmac->plat.base)) {
dev_err(&pdev->dev, "Unable to map base resource\n");
if (IS_ERR(bgmac->plat.base))
return PTR_ERR(bgmac->plat.base);
}

regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "idm_base");
if (!regs) {
Expand All @@ -141,10 +139,8 @@ static int bgmac_probe(struct platform_device *pdev)
}

bgmac->plat.idm_base = devm_ioremap_resource(&pdev->dev, regs);
if (IS_ERR(bgmac->plat.idm_base)) {
dev_err(&pdev->dev, "Unable to map idm resource\n");
if (IS_ERR(bgmac->plat.idm_base))
return PTR_ERR(bgmac->plat.idm_base);
}

bgmac->read = platform_bgmac_read;
bgmac->write = platform_bgmac_write;
Expand Down

0 comments on commit ce3a380

Please sign in to comment.