Skip to content

Commit

Permalink
net: phy: micrel: remove redundant assignment to pointer of_node
Browse files Browse the repository at this point in the history
The pointer of_node is being initialized with a value that is never
read and it is being updated later with a new value inside a do-while
loop. The initialization is redundant and can be removed and the
pointer dev is no longer required and can be removed too.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Colin Ian King authored and David S. Miller committed Jun 14, 2021
1 parent 9917060 commit ce4f8af
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/net/phy/micrel.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,7 @@ static int ksz9021_load_values_from_of(struct phy_device *phydev,

static int ksz9021_config_init(struct phy_device *phydev)
{
const struct device *dev = &phydev->mdio.dev;
const struct device_node *of_node = dev->of_node;
const struct device_node *of_node;
const struct device *dev_walker;

/* The Micrel driver has a deprecated option to place phy OF
Expand Down Expand Up @@ -711,8 +710,7 @@ static int ksz9031_config_rgmii_delay(struct phy_device *phydev)

static int ksz9031_config_init(struct phy_device *phydev)
{
const struct device *dev = &phydev->mdio.dev;
const struct device_node *of_node = dev->of_node;
const struct device_node *of_node;
static const char *clk_skews[2] = {"rxc-skew-ps", "txc-skew-ps"};
static const char *rx_data_skews[4] = {
"rxd0-skew-ps", "rxd1-skew-ps",
Expand Down Expand Up @@ -907,8 +905,7 @@ static int ksz9131_config_rgmii_delay(struct phy_device *phydev)

static int ksz9131_config_init(struct phy_device *phydev)
{
const struct device *dev = &phydev->mdio.dev;
struct device_node *of_node = dev->of_node;
struct device_node *of_node;
char *clk_skews[2] = {"rxc-skew-psec", "txc-skew-psec"};
char *rx_data_skews[4] = {
"rxd0-skew-psec", "rxd1-skew-psec",
Expand Down

0 comments on commit ce4f8af

Please sign in to comment.