Skip to content

Commit

Permalink
net: Fix napi_gro_frags vs netpoll path
Browse files Browse the repository at this point in the history
The netpoll_rx_on() check in __napi_gro_receive() skips part of the
"common" GRO_NORMAL path, especially "pull:" in dev_gro_receive(),
where at least eth header should be copied for entirely paged skbs.

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jarek Poplawski authored and David S. Miller committed Aug 5, 2010
1 parent 23d23e4 commit ce9e76c
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions net/core/dev.c
Original file line number Diff line number Diff line change
@@ -3072,7 +3072,7 @@ enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
int mac_len;
enum gro_result ret;

if (!(skb->dev->features & NETIF_F_GRO))
if (!(skb->dev->features & NETIF_F_GRO) || netpoll_rx_on(skb))
goto normal;

if (skb_is_gso(skb) || skb_has_frags(skb))
@@ -3159,9 +3159,6 @@ __napi_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
{
struct sk_buff *p;

if (netpoll_rx_on(skb))
return GRO_NORMAL;

for (p = napi->gro_list; p; p = p->next) {
NAPI_GRO_CB(p)->same_flow =
(p->dev == skb->dev) &&

0 comments on commit ce9e76c

Please sign in to comment.