Skip to content

Commit

Permalink
NFSv4: Cache the NFSv4/v4.1 client owner_id in the struct nfs_client
Browse files Browse the repository at this point in the history
Ensure that we cache the NFSv4/v4.1 client owner_id so that we can
verify it when we're doing trunking detection.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
  • Loading branch information
Trond Myklebust committed Jan 6, 2015
1 parent 1fc0703 commit ceb3a16
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 4 deletions.
1 change: 1 addition & 0 deletions fs/nfs/nfs4client.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ static void nfs4_shutdown_client(struct nfs_client *clp)
kfree(clp->cl_serverowner);
kfree(clp->cl_serverscope);
kfree(clp->cl_implid);
kfree(clp->cl_owner_id);
}

void nfs4_free_client(struct nfs_client *clp)
Expand Down
19 changes: 15 additions & 4 deletions fs/nfs/nfs4proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -4917,11 +4917,14 @@ static void nfs4_init_boot_verifier(const struct nfs_client *clp,
}

static unsigned int
nfs4_init_nonuniform_client_string(const struct nfs_client *clp,
nfs4_init_nonuniform_client_string(struct nfs_client *clp,
char *buf, size_t len)
{
unsigned int result;

if (clp->cl_owner_id != NULL)
return strlcpy(buf, clp->cl_owner_id, len);

rcu_read_lock();
result = scnprintf(buf, len, "Linux NFSv4.0 %s/%s %s",
clp->cl_ipaddr,
Expand All @@ -4930,24 +4933,32 @@ nfs4_init_nonuniform_client_string(const struct nfs_client *clp,
rpc_peeraddr2str(clp->cl_rpcclient,
RPC_DISPLAY_PROTO));
rcu_read_unlock();
clp->cl_owner_id = kstrdup(buf, GFP_KERNEL);
return result;
}

static unsigned int
nfs4_init_uniform_client_string(const struct nfs_client *clp,
nfs4_init_uniform_client_string(struct nfs_client *clp,
char *buf, size_t len)
{
const char *nodename = clp->cl_rpcclient->cl_nodename;
unsigned int result;

if (clp->cl_owner_id != NULL)
return strlcpy(buf, clp->cl_owner_id, len);

if (nfs4_client_id_uniquifier[0] != '\0')
return scnprintf(buf, len, "Linux NFSv%u.%u %s/%s",
result = scnprintf(buf, len, "Linux NFSv%u.%u %s/%s",
clp->rpc_ops->version,
clp->cl_minorversion,
nfs4_client_id_uniquifier,
nodename);
return scnprintf(buf, len, "Linux NFSv%u.%u %s",
else
result = scnprintf(buf, len, "Linux NFSv%u.%u %s",
clp->rpc_ops->version, clp->cl_minorversion,
nodename);
clp->cl_owner_id = kstrdup(buf, GFP_KERNEL);
return result;
}

/*
Expand Down
3 changes: 3 additions & 0 deletions include/linux/nfs_fs_sb.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ struct nfs_client {
/* idmapper */
struct idmap * cl_idmap;

/* Client owner identifier */
const char * cl_owner_id;

/* Our own IP address, as a null-terminated string.
* This is used to generate the mv0 callback address.
*/
Expand Down

0 comments on commit ceb3a16

Please sign in to comment.