Skip to content

Commit

Permalink
module: Convert default symbol namespace to string literal
Browse files Browse the repository at this point in the history
Commit cdd30eb ("module: Convert symbol namespace to string
literal") only converted MODULE_IMPORT_NS() and EXPORT_SYMBOL_NS(),
leaving DEFAULT_SYMBOL_NAMESPACE as a macro expansion.

This commit converts DEFAULT_SYMBOL_NAMESPACE in the same way to avoid
annoyance for the default namespace as well.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Masahiro Yamada authored and Linus Torvalds committed Dec 3, 2024
1 parent 3727b1a commit ceb8bf2
Show file tree
Hide file tree
Showing 18 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions Documentation/core-api/symbol-namespaces.rst
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ is to define the default namespace in the ``Makefile`` of the subsystem. E.g. to
export all symbols defined in usb-common into the namespace USB_COMMON, add a
line like this to drivers/usb/common/Makefile::

ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_COMMON
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"USB_COMMON"'

That will affect all EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL() statements. A
symbol exported with EXPORT_SYMBOL_NS() while this definition is present, will
Expand All @@ -79,7 +79,7 @@ A second option to define the default namespace is directly in the compilation
unit as preprocessor statement. The above example would then read::

#undef DEFAULT_SYMBOL_NAMESPACE
#define DEFAULT_SYMBOL_NAMESPACE USB_COMMON
#define DEFAULT_SYMBOL_NAMESPACE "USB_COMMON"

within the corresponding compilation unit before any EXPORT_SYMBOL macro is
used.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Per esempio per esportare tutti i simboli definiti in usb-common nello spazio
dei nomi USB_COMMON, si può aggiungere la seguente linea in
drivers/usb/common/Makefile::

ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_COMMON
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"USB_COMMON"'

Questo cambierà tutte le macro EXPORT_SYMBOL() ed EXPORT_SYMBOL_GPL(). Invece,
un simbolo esportato con EXPORT_SYMBOL_NS() non verrà cambiato e il simbolo
Expand All @@ -79,7 +79,7 @@ Una seconda possibilità è quella di definire il simbolo di preprocessore
direttamente nei file da compilare. L'esempio precedente diventerebbe::

#undef DEFAULT_SYMBOL_NAMESPACE
#define DEFAULT_SYMBOL_NAMESPACE USB_COMMON
#define DEFAULT_SYMBOL_NAMESPACE "USB_COMMON"

Questo va messo prima di un qualsiasi uso di EXPORT_SYMBOL.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
子系统的 ``Makefile`` 中定义默认命名空间。例如,如果要将usb-common中定义的所有符号导
出到USB_COMMON命名空间,可以在drivers/usb/common/Makefile中添加这样一行::

ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_COMMON
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"USB_COMMON"'

这将影响所有 EXPORT_SYMBOL() 和 EXPORT_SYMBOL_GPL() 语句。当这个定义存在时,
用EXPORT_SYMBOL_NS()导出的符号仍然会被导出到作为命名空间参数传递的命名空间中,
Expand All @@ -76,7 +76,7 @@
成::

#undef DEFAULT_SYMBOL_NAMESPACE
#define DEFAULT_SYMBOL_NAMESPACE USB_COMMON
#define DEFAULT_SYMBOL_NAMESPACE "USB_COMMON"

应置于相关编译单元中任何 EXPORT_SYMBOL 宏之前

Expand Down
2 changes: 1 addition & 1 deletion drivers/cdx/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Copyright (C) 2022-2023, Advanced Micro Devices, Inc.
#

ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=CDX_BUS
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"CDX_BUS"'

obj-$(CONFIG_CDX_BUS) += cdx.o controller/

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/intel/iaa/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Makefile for IAA crypto device drivers
#

ccflags-y += -I $(srctree)/drivers/dma/idxd -DDEFAULT_SYMBOL_NAMESPACE=IDXD
ccflags-y += -I $(srctree)/drivers/dma/idxd -DDEFAULT_SYMBOL_NAMESPACE='"IDXD"'

obj-$(CONFIG_CRYPTO_DEV_IAA_CRYPTO) := iaa_crypto.o

Expand Down
2 changes: 1 addition & 1 deletion drivers/crypto/intel/qat/qat_common/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_CRYPTO_DEV_QAT) += intel_qat.o
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=CRYPTO_QAT
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"CRYPTO_QAT"'
intel_qat-objs := adf_cfg.o \
adf_isr.o \
adf_ctl_drv.o \
Expand Down
2 changes: 1 addition & 1 deletion drivers/dma/idxd/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=IDXD
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"IDXD"'

obj-$(CONFIG_INTEL_IDXD_BUS) += idxd_bus.o
idxd_bus-y := bus.o
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-idio-16.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#include "gpio-idio-16.h"

#define DEFAULT_SYMBOL_NAMESPACE GPIO_IDIO_16
#define DEFAULT_SYMBOL_NAMESPACE "GPIO_IDIO_16"

#define IDIO_16_DAT_BASE 0x0
#define IDIO_16_OUT_BASE IDIO_16_DAT_BASE
Expand Down
2 changes: 1 addition & 1 deletion drivers/hwmon/nct6775-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
#include "nct6775.h"

#undef DEFAULT_SYMBOL_NAMESPACE
#define DEFAULT_SYMBOL_NAMESPACE HWMON_NCT6775
#define DEFAULT_SYMBOL_NAMESPACE "HWMON_NCT6775"

#define USE_ALTERNATE

Expand Down
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-designware-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include <linux/types.h>
#include <linux/units.h>

#define DEFAULT_SYMBOL_NAMESPACE I2C_DW_COMMON
#define DEFAULT_SYMBOL_NAMESPACE "I2C_DW_COMMON"

#include "i2c-designware-core.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-designware-master.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include <linux/regmap.h>
#include <linux/reset.h>

#define DEFAULT_SYMBOL_NAMESPACE I2C_DW
#define DEFAULT_SYMBOL_NAMESPACE "I2C_DW"

#include "i2c-designware-core.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-designware-slave.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include <linux/pm_runtime.h>
#include <linux/regmap.h>

#define DEFAULT_SYMBOL_NAMESPACE I2C_DW
#define DEFAULT_SYMBOL_NAMESPACE "I2C_DW"

#include "i2c-designware-core.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/pwm/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Copyright (C) 2011-2012 Avionic Design GmbH
*/

#define DEFAULT_SYMBOL_NAMESPACE PWM
#define DEFAULT_SYMBOL_NAMESPACE "PWM"

#include <linux/acpi.h>
#include <linux/module.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/pwm/pwm-dwc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* Author: Raymond Tan <raymond.tan@intel.com>
*/

#define DEFAULT_SYMBOL_NAMESPACE dwc_pwm
#define DEFAULT_SYMBOL_NAMESPACE "dwc_pwm"

#include <linux/bitops.h>
#include <linux/export.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/pwm/pwm-lpss.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include <linux/pm_runtime.h>
#include <linux/time.h>

#define DEFAULT_SYMBOL_NAMESPACE PWM_LPSS
#define DEFAULT_SYMBOL_NAMESPACE "PWM_LPSS"

#include "pwm-lpss.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/tty/serial/sc16is7xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/

#undef DEFAULT_SYMBOL_NAMESPACE
#define DEFAULT_SYMBOL_NAMESPACE SERIAL_NXP_SC16IS7XX
#define DEFAULT_SYMBOL_NAMESPACE "SERIAL_NXP_SC16IS7XX"

#include <linux/bits.h>
#include <linux/clk.h>
Expand Down
2 changes: 1 addition & 1 deletion drivers/usb/storage/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

ccflags-y := -I $(srctree)/drivers/scsi

ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=USB_STORAGE
ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE='"USB_STORAGE"'

obj-$(CONFIG_USB_UAS) += uas.o
obj-$(CONFIG_USB_STORAGE) += usb-storage.o
Expand Down
2 changes: 1 addition & 1 deletion include/linux/export.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
#endif

#ifdef DEFAULT_SYMBOL_NAMESPACE
#define _EXPORT_SYMBOL(sym, license) __EXPORT_SYMBOL(sym, license, __stringify(DEFAULT_SYMBOL_NAMESPACE))
#define _EXPORT_SYMBOL(sym, license) __EXPORT_SYMBOL(sym, license, DEFAULT_SYMBOL_NAMESPACE)
#else
#define _EXPORT_SYMBOL(sym, license) __EXPORT_SYMBOL(sym, license, "")
#endif
Expand Down

0 comments on commit ceb8bf2

Please sign in to comment.