Skip to content

Commit

Permalink
timekeeping: Move ADJ_SETOFFSET to top level do_adjtimex()
Browse files Browse the repository at this point in the history
Since ADJ_SETOFFSET adjusts the timekeeping state, process
it as part of the top level do_adjtimex() function in
timekeeping.c.

This avoids deadlocks that could occur once we change the
ntp locking rules.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
  • Loading branch information
John Stultz committed Apr 4, 2013
1 parent 87ace39 commit cef9037
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
11 changes: 0 additions & 11 deletions kernel/time/ntp.c
Original file line number Diff line number Diff line change
Expand Up @@ -666,17 +666,6 @@ int __do_adjtimex(struct timex *txc, struct timespec *ts, s32 *time_tai)
{
int result;

if (txc->modes & ADJ_SETOFFSET) {
struct timespec delta;
delta.tv_sec = txc->time.tv_sec;
delta.tv_nsec = txc->time.tv_usec;
if (!(txc->modes & ADJ_NANO))
delta.tv_nsec *= 1000;
result = timekeeping_inject_offset(&delta);
if (result)
return result;
}

raw_spin_lock_irq(&ntp_lock);

if (txc->modes & ADJ_ADJTIME) {
Expand Down
11 changes: 11 additions & 0 deletions kernel/time/timekeeping.c
Original file line number Diff line number Diff line change
Expand Up @@ -1627,6 +1627,17 @@ int do_adjtimex(struct timex *txc)
if (ret)
return ret;

if (txc->modes & ADJ_SETOFFSET) {
struct timespec delta;
delta.tv_sec = txc->time.tv_sec;
delta.tv_nsec = txc->time.tv_usec;
if (!(txc->modes & ADJ_NANO))
delta.tv_nsec *= 1000;
ret = timekeeping_inject_offset(&delta);
if (ret)
return ret;
}

getnstimeofday(&ts);
orig_tai = tai = timekeeping_get_tai_offset();

Expand Down

0 comments on commit cef9037

Please sign in to comment.