Skip to content

Commit

Permalink
sb_edac: use "event" instead of "exception" when MC wasnt signaled
Browse files Browse the repository at this point in the history
Corrected Errors are MC events, not exceptions and reporting as the
later might confuse users.

Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
  • Loading branch information
Aristeu Rozanski authored and Mauro Carvalho Chehab committed Mar 13, 2014
1 parent fa389e2 commit cf40f80
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/edac/sb_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1828,6 +1828,7 @@ static int sbridge_mce_check_error(struct notifier_block *nb, unsigned long val,
struct mce *mce = (struct mce *)data;
struct mem_ctl_info *mci;
struct sbridge_pvt *pvt;
char *type;

if (get_edac_report_status() == EDAC_REPORTING_DISABLED)
return NOTIFY_DONE;
Expand All @@ -1846,10 +1847,15 @@ static int sbridge_mce_check_error(struct notifier_block *nb, unsigned long val,
if ((mce->status & 0xefff) >> 7 != 1)
return NOTIFY_DONE;

if (mce->mcgstatus & MCG_STATUS_MCIP)
type = "Exception";
else
type = "Event";

printk("sbridge: HANDLING MCE MEMORY ERROR\n");

printk("CPU %d: Machine Check Exception: %Lx Bank %d: %016Lx\n",
mce->extcpu, mce->mcgstatus, mce->bank, mce->status);
printk("CPU %d: Machine Check %s: %Lx Bank %d: %016Lx\n",
mce->extcpu, type, mce->mcgstatus, mce->bank, mce->status);
printk("TSC %llx ", mce->tsc);
printk("ADDR %llx ", mce->addr);
printk("MISC %llx ", mce->misc);
Expand Down

0 comments on commit cf40f80

Please sign in to comment.