Skip to content

Commit

Permalink
net: devlink: clean-up empty devlink_ops::info_get()
Browse files Browse the repository at this point in the history
devlink_ops::info_get() is now optional and devlink will continue to
report information even if that callback gets removed.

Remove all the empty devlink_ops::info_get() callbacks from the
drivers.

Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Jacob Keller  <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Vincent Mailhol authored and Jakub Kicinski committed Dec 1, 2022
1 parent c5cd7c8 commit cf4590b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 22 deletions.
7 changes: 0 additions & 7 deletions drivers/net/ethernet/fungible/funeth/funeth_devlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,7 @@
#include "funeth.h"
#include "funeth_devlink.h"

static int fun_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
struct netlink_ext_ack *extack)
{
return 0;
}

static const struct devlink_ops fun_dl_ops = {
.info_get = fun_dl_info_get,
};

struct devlink *fun_devlink_alloc(struct device *dev)
Expand Down
7 changes: 0 additions & 7 deletions drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1547,14 +1547,7 @@ static int rvu_devlink_eswitch_mode_set(struct devlink *devlink, u16 mode,
return 0;
}

static int rvu_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
struct netlink_ext_ack *extack)
{
return 0;
}

static const struct devlink_ops rvu_devlink_ops = {
.info_get = rvu_devlink_info_get,
.eswitch_mode_get = rvu_devlink_eswitch_mode_get,
.eswitch_mode_set = rvu_devlink_eswitch_mode_set,
};
Expand Down
8 changes: 0 additions & 8 deletions drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,7 @@ static const struct devlink_param otx2_dl_params[] = {
otx2_dl_mcam_count_validate),
};

static int otx2_devlink_info_get(struct devlink *devlink,
struct devlink_info_req *req,
struct netlink_ext_ack *extack)
{
return 0;
}

static const struct devlink_ops otx2_devlink_ops = {
.info_get = otx2_devlink_info_get,
};

int otx2_register_dl(struct otx2_nic *pfvf)
Expand Down

0 comments on commit cf4590b

Please sign in to comment.