-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add scripts/coccinelle/alloc/kzalloc-simple.cocci
This semantic patch replaces a pair of calls to kmalloc and memset by a single call to kzalloc. It only looks for simple cases to avoid false positives. Signed-off-by: Nicolas Palix <npalix@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Michal Marek <mmarek@suse.cz>
- Loading branch information
Nicolas Palix
authored and
Michal Marek
committed
Jun 11, 2010
1 parent
51169c8
commit cf5842d
Showing
1 changed file
with
82 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/// | ||
/// kzalloc should be used rather than kmalloc followed by memset 0 | ||
/// | ||
// Confidence: High | ||
// Copyright: (C) 2009-2010 Julia Lawall, Nicolas Palix, DIKU. GPLv2. | ||
// Copyright: (C) 2009-2010 Gilles Muller, INRIA/LiP6. GPLv2. | ||
// URL: http://coccinelle.lip6.fr/rules/kzalloc.html | ||
// Options: -no_includes -include_headers | ||
// | ||
// Keywords: kmalloc, kzalloc | ||
// Version min: < 2.6.12 kmalloc | ||
// Version min: 2.6.14 kzalloc | ||
// | ||
|
||
virtual context | ||
virtual patch | ||
virtual org | ||
virtual report | ||
|
||
//---------------------------------------------------------- | ||
// For context mode | ||
//---------------------------------------------------------- | ||
|
||
@depends on context@ | ||
type T, T2; | ||
expression x; | ||
expression E1,E2; | ||
statement S; | ||
@@ | ||
|
||
* x = (T)kmalloc(E1,E2); | ||
if ((x==NULL) || ...) S | ||
* memset((T2)x,0,E1); | ||
|
||
//---------------------------------------------------------- | ||
// For patch mode | ||
//---------------------------------------------------------- | ||
|
||
@depends on patch@ | ||
type T, T2; | ||
expression x; | ||
expression E1,E2; | ||
statement S; | ||
@@ | ||
|
||
- x = (T)kmalloc(E1,E2); | ||
+ x = kzalloc(E1,E2); | ||
if ((x==NULL) || ...) S | ||
- memset((T2)x,0,E1); | ||
|
||
//---------------------------------------------------------- | ||
// For org mode | ||
//---------------------------------------------------------- | ||
|
||
@r depends on org || report@ | ||
type T, T2; | ||
expression x; | ||
expression E1,E2; | ||
statement S; | ||
position p; | ||
@@ | ||
|
||
x = (T)kmalloc@p(E1,E2); | ||
if ((x==NULL) || ...) S | ||
memset((T2)x,0,E1); | ||
|
||
@script:python depends on org@ | ||
p << r.p; | ||
x << r.x; | ||
@@ | ||
msg="%s" % (x) | ||
msg_safe=msg.replace("[","@(").replace("]",")") | ||
coccilib.org.print_todo(p[0], msg_safe) | ||
@script:python depends on report@ | ||
p << r.p; | ||
x << r.x; | ||
@@ | ||
msg="WARNING: kzalloc should be used for %s, instead of kmalloc/memset" % (x) | ||
coccilib.report.print_report(p[0], msg) |