can: gs_usb: gs_destroy_candev(): fix use after free

This patch fixes a use after free of "dev" in gs_destroy_candev(). Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
mariux64 · May 21, 2014 · cf68f51 · cf68f51
1 parent 2a7ede5
commit cf68f51
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
@@ -826,8 +826,8 @@ static void gs_destroy_candev(struct gs_can *dev)
 {
 	unregister_candev(dev->netdev);
 	free_candev(dev->netdev);
-	kfree(dev);
 	usb_kill_anchored_urbs(&dev->tx_submitted);
+	kfree(dev);
 }
 
 static int gs_usb_probe(struct usb_interface *intf, const struct usb_device_id *id)