Skip to content

Commit

Permalink
Btrfs: fix possible memory leak in scrub_setup_recheck_block()
Browse files Browse the repository at this point in the history
bbio has been malloced in btrfs_map_block() and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
  • Loading branch information
Wei Yongjun authored and Chris Mason committed Oct 1, 2012
1 parent 7014cdb commit cf93dcc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/btrfs/scrub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,7 @@ static int scrub_setup_recheck_block(struct scrub_dev *sdev,
spin_lock(&sdev->stat_lock);
sdev->stat.malloc_errors++;
spin_unlock(&sdev->stat_lock);
kfree(bbio);
return -ENOMEM;
}
sblock->page_count++;
Expand Down

0 comments on commit cf93dcc

Please sign in to comment.