Skip to content

Commit

Permalink
ALSA: usb: midi: don't return -ENOMEM when usb_urb_ep_type_check fails
Browse files Browse the repository at this point in the history
Currently when the call to usb_urb_ep_type_check fails (returning -EINVAL)
the error return path returns -ENOMEM via the exit label "error". Other
uses of the same error exit label set the err variable to -ENOMEM but this
is not being used.  I believe the original intent was for the error exit
path to return the value in err rather than the hard coded -ENOMEM, so
return this rather than the hard coded -ENOMEM.

Addresses-Coverity: ("Unused value")
Fixes: 738d9ed ("ALSA: usb-audio: Add sanity checks for invalid EPs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210420134719.381409-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Colin Ian King authored and Takashi Iwai committed Apr 20, 2021
1 parent bd15b15 commit cfd577a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/usb/midi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1316,7 +1316,7 @@ static int snd_usbmidi_in_endpoint_create(struct snd_usb_midi *umidi,

error:
snd_usbmidi_in_endpoint_delete(ep);
return -ENOMEM;
return err;
}

/*
Expand Down

0 comments on commit cfd577a

Please sign in to comment.