Skip to content

Commit

Permalink
staging: sm750fb: Rename maxH to max_h in lynx_cursor
Browse files Browse the repository at this point in the history
The struct lynx_cursor has a member named maxH. This name is
CamelCase and is frowned upon. This commit renames it to max_h
and makes the necessary changes for the module to build.

This change also fixes the following checkpatch CHECK:

CHECK: Avoid CamelCase: <maxH>
116: FILE: drivers/staging/sm750fb/sm750.c:116:
+           fbcursor->image.height > cursor->maxH ||

Signed-off-by: Benjamin Philip <benjamin.philip495@gmail.com>
Link: https://lore.kernel.org/r/692211000786d76aa41bc24d4ee06b5868d82771.1627304144.git.benjamin.philip495@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Benjamin Philip authored and Greg Kroah-Hartman committed Jul 27, 2021
1 parent 7b9148d commit cfdafb7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions drivers/staging/sm750fb/sm750.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)
cursor = &crtc->cursor;

if (fbcursor->image.width > cursor->maxW ||
fbcursor->image.height > cursor->maxH ||
fbcursor->image.height > cursor->max_h ||
fbcursor->image.depth > 1) {
return -ENXIO;
}
Expand Down Expand Up @@ -723,8 +723,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
0x800f0 + (int)crtc->channel * 0x140;

pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio);
crtc->cursor.maxH = crtc->cursor.maxW = 64;
crtc->cursor.size = crtc->cursor.maxH * crtc->cursor.maxW * 2 / 8;
crtc->cursor.max_h = crtc->cursor.maxW = 64;
crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.maxW * 2 / 8;
crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset;

memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/sm750fb/sm750.h
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ struct lynx_cursor {
int size;
/* hardware limitation */
int maxW;
int maxH;
int max_h;
/* base virtual address and offset of cursor image */
char __iomem *vstart;
int offset;
Expand Down

0 comments on commit cfdafb7

Please sign in to comment.