Skip to content

Commit

Permalink
drm/client: remove the exporting of drm_client_close
Browse files Browse the repository at this point in the history
The function drm_client_close is declared as static and marked as
EXPORT_SYMBOL. It's a bit confusing for an internal function to be
exported. The area of visibility for such function is its .c file
and all other modules. Other *.c files of the same module can't use it,
despite all other modules can. Relying on the fact that this is the
internal function and it's not a crucial part of the API, the patch
removes the EXPORT_SYMBOL marking of drm_client_close.

Signed-off-by: Denis Efremov <efremov@linux.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190703170150.32548-1-efremov@linux.com
  • Loading branch information
Denis Efremov authored and Noralf Trønnes committed Jul 9, 2019
1 parent 90f479a commit d006a9b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/gpu/drm/drm_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ static void drm_client_close(struct drm_client_dev *client)

drm_file_free(client->file);
}
EXPORT_SYMBOL(drm_client_close);

/**
* drm_client_init - Initialise a DRM client
Expand Down

0 comments on commit d006a9b

Please sign in to comment.