Skip to content

Commit

Permalink
mei: remove the reference to pdev from mei_device
Browse files Browse the repository at this point in the history
For purpose of adding testing HW we would like
to get rid of pci dependency in generic mei code.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Tomas Winkler authored and Greg Kroah-Hartman committed Sep 29, 2014
1 parent 1bd30b6 commit d08b8fc
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions drivers/misc/mei/hw-me.c
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ irqreturn_t mei_me_irq_thread_handler(int irq, void *dev_id)

/* Ack the interrupt here
* In case of MSI we don't go through the quick handler */
if (pci_dev_msi_enabled(dev->pdev))
if (pci_dev_msi_enabled(to_pci_dev(dev->dev)))
mei_clear_interrupts(dev);

/* check if ME wants a reset */
Expand Down Expand Up @@ -854,7 +854,6 @@ struct mei_device *mei_me_dev_init(struct pci_dev *pdev,

mei_device_init(dev, &pdev->dev, &mei_me_hw_ops);
dev->cfg = cfg;
dev->pdev = pdev;
return dev;
}

3 changes: 1 addition & 2 deletions drivers/misc/mei/hw-txe.c
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,7 @@ irqreturn_t mei_txe_irq_thread_handler(int irq, void *dev_id)
mutex_lock(&dev->device_lock);
mei_io_list_init(&complete_list);

if (pci_dev_msi_enabled(dev->pdev))
if (pci_dev_msi_enabled(to_pci_dev(dev->dev)))
mei_txe_check_and_ack_intrs(dev, true);

/* show irq events */
Expand Down Expand Up @@ -1157,7 +1157,6 @@ struct mei_device *mei_txe_dev_init(struct pci_dev *pdev,
init_waitqueue_head(&hw->wait_aliveness_resp);

dev->cfg = cfg;
dev->pdev = pdev;
return dev;
}

Expand Down
2 changes: 0 additions & 2 deletions drivers/misc/mei/mei_dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,6 @@ struct mei_cfg {
/**
* struct mei_device - MEI private device struct
* @pdev - pointer to pci device struct
* @dev - device on a bus
* @cdev - character device
* @minor - minor number allocated for device
Expand All @@ -420,7 +419,6 @@ struct mei_cfg {
* @cfg - per device generation config and ops
*/
struct mei_device {
struct pci_dev *pdev; /* pointer to pci device struct */
struct device *dev;
struct cdev cdev;
int minor;
Expand Down
2 changes: 1 addition & 1 deletion drivers/misc/mei/pci-me.c
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ static int mei_me_pm_runtime_resume(struct device *device)
*/
static inline void mei_me_set_pm_domain(struct mei_device *dev)
{
struct pci_dev *pdev = dev->pdev;
struct pci_dev *pdev = to_pci_dev(dev->dev);

if (pdev->dev.bus && pdev->dev.bus->pm) {
dev->pg_domain.ops = *pdev->dev.bus->pm;
Expand Down
2 changes: 1 addition & 1 deletion drivers/misc/mei/pci-txe.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ static int mei_txe_pm_runtime_resume(struct device *device)
*/
static inline void mei_txe_set_pm_domain(struct mei_device *dev)
{
struct pci_dev *pdev = dev->pdev;
struct pci_dev *pdev = to_pci_dev(dev->dev);

if (pdev->dev.bus && pdev->dev.bus->pm) {
dev->pg_domain.ops = *pdev->dev.bus->pm;
Expand Down

0 comments on commit d08b8fc

Please sign in to comment.