Skip to content

Commit

Permalink
NFSD: Remove dead code in nfsd4_create_session()
Browse files Browse the repository at this point in the history
Clean up. AFAICT, there is no way to reach the out_free_conn label
with @old set to a non-NULL value, so the expire_client(old) call
is never reached and can be removed.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
  • Loading branch information
Chuck Lever committed Nov 19, 2024
1 parent 4cc9b9f commit d08bf5e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -3954,7 +3954,6 @@ nfsd4_create_session(struct svc_rqst *rqstp,
return status;

out_expired_error:
old = NULL;
/*
* Revert the slot seq_nr change so the server will process
* the client's resend instead of returning a cached response.
Expand All @@ -3969,8 +3968,6 @@ nfsd4_create_session(struct svc_rqst *rqstp,
out_free_conn:
spin_unlock(&nn->client_lock);
free_conn(conn);
if (old)
expire_client(old);
out_free_session:
__free_session(new);
out_release_drc_mem:
Expand Down

0 comments on commit d08bf5e

Please sign in to comment.