Skip to content

Commit

Permalink
PM / Hibernate: Make some boot messages look less scary
Browse files Browse the repository at this point in the history
The hibernate resume code checks if there is an image to resume from
on every boot and, if the kernel is built with CONFIG_PM_DEBUG set
and the image is not present, it prints some scary messages
suggesting there was a boot error of some sort.  Apparently, some
users are confused by them, so make them look less scary and adjust
the other hibernate resume debug messages to match them.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
  • Loading branch information
Rafael J. Wysocki committed Oct 16, 2010
1 parent 15bcb91 commit d0941ea
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions kernel/power/hibernate.c
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ static int software_resume(void)
goto Unlock;
}

pr_debug("PM: Checking image partition %s\n", resume_file);
pr_debug("PM: Checking hibernation image partition %s\n", resume_file);

/* Check if the device is there */
swsusp_resume_device = name_to_dev_t(resume_file);
Expand All @@ -733,10 +733,10 @@ static int software_resume(void)
}

Check_image:
pr_debug("PM: Resume from partition %d:%d\n",
pr_debug("PM: Hibernation image partition %d:%d present\n",
MAJOR(swsusp_resume_device), MINOR(swsusp_resume_device));

pr_debug("PM: Checking hibernation image.\n");
pr_debug("PM: Looking for hibernation image.\n");
error = swsusp_check();
if (error)
goto Unlock;
Expand Down Expand Up @@ -768,14 +768,14 @@ static int software_resume(void)
goto Done;
}

pr_debug("PM: Reading hibernation image.\n");
pr_debug("PM: Loading hibernation image.\n");

error = swsusp_read(&flags);
swsusp_close(FMODE_READ);
if (!error)
hibernation_restore(flags & SF_PLATFORM_MODE);

printk(KERN_ERR "PM: Restore failed, recovering.\n");
printk(KERN_ERR "PM: Failed to load hibernation image, recovering.\n");
swsusp_free();
thaw_processes();
Done:
Expand All @@ -788,7 +788,7 @@ static int software_resume(void)
/* For success case, the suspend path will release the lock */
Unlock:
mutex_unlock(&pm_mutex);
pr_debug("PM: Resume from disk failed.\n");
pr_debug("PM: Hibernation image not present or could not be loaded.\n");
return error;
close_finish:
swsusp_close(FMODE_READ);
Expand Down
4 changes: 2 additions & 2 deletions kernel/power/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -929,13 +929,13 @@ int swsusp_check(void)
if (error)
blkdev_put(hib_resume_bdev, FMODE_READ);
else
pr_debug("PM: Signature found, resuming\n");
pr_debug("PM: Image signature found, resuming\n");
} else {
error = PTR_ERR(hib_resume_bdev);
}

if (error)
pr_debug("PM: Error %d checking image file\n", error);
pr_debug("PM: Image not found (code %d)\n", error);

return error;
}
Expand Down

0 comments on commit d0941ea

Please sign in to comment.