Skip to content

Commit

Permalink
tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
Browse files Browse the repository at this point in the history
Currently it returns zero when CRQ response timed out, it should return
an error code instead.

Fixes: d8d74ea ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
  • Loading branch information
Xiu Jianfeng authored and Jarkko Sakkinen committed May 23, 2022
1 parent 80b8a39 commit d0dc1a7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/char/tpm/tpm_ibmvtpm.c
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
ibmvtpm->rtce_buf != NULL,
HZ)) {
rc = -ENODEV;
dev_err(dev, "CRQ response timed out\n");
goto init_irq_cleanup;
}
Expand Down

0 comments on commit d0dc1a7

Please sign in to comment.