Skip to content

Commit

Permalink
selftests: net: report output format as TAP 13 in Python tests
Browse files Browse the repository at this point in the history
The Python lib based tests report that they are producing
"KTAP version 1", but really we aren't making use of any
KTAP features, like subtests. Our output is plain TAP.

Report TAP 13 instead of KTAP 1, this is what mptcp tests do,
and what NIPA knows how to parse best. For HW testing we need
precise subtest result tracking.

Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250228180007.83325-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jakub Kicinski committed Mar 3, 2025
1 parent f77f120 commit d110dbf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tools/testing/selftests/drivers/net/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ On the target machine, running the tests will use netdevsim by default::
1..1
# timeout set to 45
# selftests: drivers/net: ping.py
# KTAP version 1
# TAP version 13
# 1..3
# ok 1 ping.test_v4
# ok 2 ping.test_v6
Expand All @@ -128,7 +128,7 @@ Create a config with remote info::
Run the test::

[/root] # ./ksft-net-drv/drivers/net/ping.py
KTAP version 1
TAP version 13
1..3
ok 1 ping.test_v4
ok 2 ping.test_v6 # SKIP Test requires IPv6 connectivity
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/net/lib/py/ksft.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def ksft_run(cases=None, globs=None, case_pfx=None, args=()):

totals = {"pass": 0, "fail": 0, "skip": 0, "xfail": 0}

print("KTAP version 1")
print("TAP version 13")
print("1.." + str(len(cases)))

global KSFT_RESULT
Expand Down

0 comments on commit d110dbf

Please sign in to comment.