Skip to content

Commit

Permalink
via-rhine: Fix for the hardware having a reset failure after resume
Browse files Browse the repository at this point in the history
In rhine_resume() and rhine_suspend(), the code calls netif_running()
to see if the network interface is down or not.  If it is down (i.e.,
netif_running() returning false), they will skip any housekeeping work
within the function relating to the hardware.  This becomes a problem
when the hardware resumes from a standby since it is counting on
rhine_resume() to map its MMIO and power up rest of the hardware.
Not getting its MMIO remapped and rest of the hardware powered
up lead to a soft reset failure and hardware disappearance.  The
solution is to map its MMIO and power up rest of the hardware inside
rhine_open() before soft reset is to be performed.  This solution was
verified on ASUS P5V800-VM mainboard's integrated Rhine-II Ethernet
MAC inside VIA Technologies VT8251 South Bridge.

Signed-off-by: Kevin Brace <kevinbrace@bracecomputerlab.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kevin Brace authored and David S. Miller committed Sep 29, 2020
1 parent 6667df9 commit d120c9a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/ethernet/via/via-rhine.c
Original file line number Diff line number Diff line change
Expand Up @@ -1706,6 +1706,8 @@ static int rhine_open(struct net_device *dev)
goto out_free_ring;

alloc_tbufs(dev);
enable_mmio(rp->pioaddr, rp->quirks);
rhine_power_init(dev);
rhine_chip_reset(dev);
rhine_task_enable(rp);
init_registers(dev);
Expand Down

0 comments on commit d120c9a

Please sign in to comment.