Skip to content

Commit

Permalink
block: remove support for delayed queue registrations
Browse files Browse the repository at this point in the history
Now that device mapper has been changed to register the disk once
it is fully ready all this code is unused.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Link: https://lore.kernel.org/r/20210804094147.459763-9-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Aug 9, 2021
1 parent 89f871a commit d1254a8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 29 deletions.
1 change: 0 additions & 1 deletion block/elevator.c
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,6 @@ void elevator_init_mq(struct request_queue *q)
elevator_put(e);
}
}
EXPORT_SYMBOL_GPL(elevator_init_mq); /* only for dm-rq */

/*
* switch to new_e io scheduler. be careful not to introduce deadlocks -
Expand Down
29 changes: 7 additions & 22 deletions block/genhd.c
Original file line number Diff line number Diff line change
Expand Up @@ -475,20 +475,20 @@ static void register_disk(struct device *parent, struct gendisk *disk,
}

/**
* __device_add_disk - add disk information to kernel list
* device_add_disk - add disk information to kernel list
* @parent: parent device for the disk
* @disk: per-device partitioning information
* @groups: Additional per-device sysfs groups
* @register_queue: register the queue if set to true
*
* This function registers the partitioning information in @disk
* with the kernel.
*
* FIXME: error handling
*/
static void __device_add_disk(struct device *parent, struct gendisk *disk,
const struct attribute_group **groups,
bool register_queue)

void device_add_disk(struct device *parent, struct gendisk *disk,
const struct attribute_group **groups)

{
int ret;

Expand All @@ -498,8 +498,7 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
* elevator if one is needed, that is, for devices requesting queue
* registration.
*/
if (register_queue)
elevator_init_mq(disk->queue);
elevator_init_mq(disk->queue);

/*
* If the driver provides an explicit major number it also must provide
Expand Down Expand Up @@ -553,8 +552,7 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
bdev_add(disk->part0, dev->devt);
}
register_disk(parent, disk, groups);
if (register_queue)
blk_register_queue(disk);
blk_register_queue(disk);

/*
* Take an extra ref on queue which will be put on disk_release()
Expand All @@ -568,21 +566,8 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk,
disk_add_events(disk);
blk_integrity_add(disk);
}

void device_add_disk(struct device *parent, struct gendisk *disk,
const struct attribute_group **groups)

{
__device_add_disk(parent, disk, groups, true);
}
EXPORT_SYMBOL(device_add_disk);

void device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk)
{
__device_add_disk(parent, disk, NULL, false);
}
EXPORT_SYMBOL(device_add_disk_no_queue_reg);

/**
* del_gendisk - remove the gendisk
* @disk: the struct gendisk to remove
Expand Down
6 changes: 0 additions & 6 deletions include/linux/genhd.h
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,6 @@ static inline void add_disk(struct gendisk *disk)
{
device_add_disk(NULL, disk, NULL);
}
extern void device_add_disk_no_queue_reg(struct device *parent, struct gendisk *disk);
static inline void add_disk_no_queue_reg(struct gendisk *disk)
{
device_add_disk_no_queue_reg(NULL, disk);
}

extern void del_gendisk(struct gendisk *gp);

void set_disk_ro(struct gendisk *disk, bool read_only);
Expand Down

0 comments on commit d1254a8

Please sign in to comment.