Skip to content

Commit

Permalink
tipc: do not use tasklet_disable before tasklet_kill
Browse files Browse the repository at this point in the history
If tasklet_disable() is called before related tasklet handled,
tasklet_kill will never be finished. tasklet_kill is enough.

Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Allan Stephens <allan.stephens@windriver.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: tipc-discussion@lists.sourceforge.net
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Xiaotian Feng authored and David S. Miller committed Nov 3, 2012
1 parent 0f89a57 commit d145f7e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion net/tipc/handler.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ void tipc_handler_stop(void)
return;

handler_enabled = 0;
tasklet_disable(&tipc_tasklet);
tasklet_kill(&tipc_tasklet);

spin_lock_bh(&qitem_lock);
Expand Down

0 comments on commit d145f7e

Please sign in to comment.