Skip to content

Commit

Permalink
e1000e: Use PME poll to circumvent unreliable ACPI wake
Browse files Browse the repository at this point in the history
On some I219 devices, ethernet cable plugging detection only works once
from PCI D3 state. Subsequent cable plugging does set PME bit correctly,
but device still doesn't get woken up.

Since I219 connects to the root complex directly, it relies on platform
firmware (ACPI) to wake it up. In this case, the GPE from _PRW only
works for first cable plugging but fails to notify the driver for
subsequent plugging events.

The issue was originally found on CNP, but the same issue can be found
on ADL too. So workaround the issue by continuing use PME poll after
first ACPI wake. As PME poll is always used, the runtime suspend
restriction for CNP can also be removed.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kai-Heng Feng authored and David S. Miller committed Aug 16, 2023
1 parent ac8a529 commit d147085
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/ethernet/intel/e1000e/netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -7021,6 +7021,8 @@ static __maybe_unused int e1000e_pm_runtime_resume(struct device *dev)
struct e1000_adapter *adapter = netdev_priv(netdev);
int rc;

pdev->pme_poll = true;

rc = __e1000_resume(pdev);
if (rc)
return rc;
Expand Down Expand Up @@ -7682,7 +7684,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)

dev_pm_set_driver_flags(&pdev->dev, DPM_FLAG_SMART_PREPARE);

if (pci_dev_run_wake(pdev) && hw->mac.type != e1000_pch_cnp)
if (pci_dev_run_wake(pdev))
pm_runtime_put_noidle(&pdev->dev);

return 0;
Expand Down

0 comments on commit d147085

Please sign in to comment.