Skip to content

Commit

Permalink
ALSA: synth: missing check for possible NULL after the call to kstrdup
Browse files Browse the repository at this point in the history
If kcalloc() return NULL due to memory starvation, it is possible for
kstrdup() to return NULL in similar case. So add null check after the call
to kstrdup() is made.

[ minor coding-style fix by tiwai ]

Signed-off-by: Austin Kim <austin.kim@lge.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20211109003742.GA5423@raspberrypi
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Austin Kim authored and Takashi Iwai committed Nov 9, 2021
1 parent ad4f93c commit d159037
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/synth/emux/emux.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ int snd_emux_register(struct snd_emux *emu, struct snd_card *card, int index, ch
emu->name = kstrdup(name, GFP_KERNEL);
emu->voices = kcalloc(emu->max_voices, sizeof(struct snd_emux_voice),
GFP_KERNEL);
if (emu->voices == NULL)
if (emu->name == NULL || emu->voices == NULL)
return -ENOMEM;

/* create soundfont list */
Expand Down

0 comments on commit d159037

Please sign in to comment.