Skip to content

Commit

Permalink
dmatest: make driver unmap also source buffers by itself
Browse files Browse the repository at this point in the history
Make the driver DMA unmap also source buffers by itself
(currently it DMA unmaps only destination buffers) as
a preparation for introducing generic 'ummap' data.

Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz authored and Dan Williams committed Nov 13, 2013
1 parent 31d141e commit d1cab34
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/dma/dmatest.c
Original file line number Diff line number Diff line change
Expand Up @@ -597,11 +597,10 @@ static int dmatest_func(void *data)
set_user_nice(current, 10);

/*
* src buffers are freed by the DMAEngine code with dma_unmap_single()
* dst buffers are freed by ourselves below
* src and dst buffers are freed by ourselves below
*/
flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT
| DMA_COMPL_SKIP_DEST_UNMAP | DMA_COMPL_SRC_UNMAP_SINGLE;
flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT |
DMA_COMPL_SKIP_SRC_UNMAP | DMA_COMPL_SKIP_DEST_UNMAP;

while (!kthread_should_stop()
&& !(params->iterations && total_tests >= params->iterations)) {
Expand Down Expand Up @@ -750,7 +749,8 @@ static int dmatest_func(void *data)
continue;
}

/* Unmap by myself (see DMA_COMPL_SKIP_DEST_UNMAP above) */
/* Unmap by myself */
unmap_src(dev->dev, dma_srcs, len, src_cnt);
unmap_dst(dev->dev, dma_dsts, params->buf_size, dst_cnt);

error_count = 0;
Expand Down

0 comments on commit d1cab34

Please sign in to comment.