Skip to content

Commit

Permalink
cpufreq: sun50i: Fix build warning around snprint()
Browse files Browse the repository at this point in the history
The Sun50i driver generates a warning with W=1:

warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]

Fix it by allocating a big enough array to print an integer.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404191715.LDwMm2gP-lkp@intel.com/
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
  • Loading branch information
Viresh Kumar committed Apr 23, 2024
1 parent 09d0aaa commit d2059d3
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/cpufreq/sun50i-cpufreq-nvmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
#include <linux/pm_opp.h>
#include <linux/slab.h>

#define MAX_NAME_LEN 7

#define NVMEM_MASK 0x7
#define NVMEM_SHIFT 5

Expand Down Expand Up @@ -208,7 +206,7 @@ static int sun50i_cpufreq_get_efuse(void)
static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
{
int *opp_tokens;
char name[MAX_NAME_LEN];
char name[] = "speedXXXXXXXXXXX"; /* Integers can take 11 chars max */
unsigned int cpu, supported_hw;
struct dev_pm_opp_config config = {};
int speed;
Expand All @@ -235,7 +233,7 @@ static int sun50i_cpufreq_nvmem_probe(struct platform_device *pdev)
config.supported_hw_count = 1;
}

snprintf(name, MAX_NAME_LEN, "speed%d", speed);
snprintf(name, sizeof(name), "speed%d", speed);
config.prop_name = name;

for_each_possible_cpu(cpu) {
Expand Down

0 comments on commit d2059d3

Please sign in to comment.