Skip to content

Commit

Permalink
arm64: dts: qcom: sc7180-trogdor: Simplify spi0/spi6 labeling
Browse files Browse the repository at this point in the history
We had to do this spi0/spi6 flip-flop on trogdor-r0 because the spi
buses got swizzled between r0 and r1. The swizzle stopped after r1, but
we kept this around to support either hardware possibility and to keep
trogdor-r0 working.

trogdor-r0 isn't supported upstream, so this swizzle is not doing
anything besides making a pattern that others tryt  to copy for the EC and
H1 nodes. Let's remove it and simplify the dts files.

Cc: "Joseph S. Barrera III" <joebar@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220427020339.360855-3-swboyd@chromium.org
  • Loading branch information
Stephen Boyd authored and Bjorn Andersson committed May 6, 2022
1 parent 51d3040 commit d277cab
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 21 deletions.
6 changes: 1 addition & 5 deletions arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,10 @@
*/

#include "sc7180.dtsi"

ap_ec_spi: &spi6 {};
ap_h1_spi: &spi0 {};

#include "sc7180-trogdor.dtsi"
#include "sc7180-trogdor-ti-sn65dsi86.dtsi"

/* Deleted nodes from trogdor.dtsi */
/* Deleted nodes from sc7180-trogdor.dtsi */

/delete-node/ &alc5682;
/delete-node/ &pp3300_codec;
Expand Down
3 changes: 0 additions & 3 deletions arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
* Copyright 2021 Google LLC.
*/

ap_ec_spi: &spi6 {};
ap_h1_spi: &spi0 {};

#include "sc7180-trogdor.dtsi"

/ {
Expand Down
3 changes: 0 additions & 3 deletions arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
* Copyright 2020 Google LLC.
*/

ap_ec_spi: &spi6 {};
ap_h1_spi: &spi0 {};

#include "sc7180-trogdor.dtsi"

&ap_sar_sensor {
Expand Down
4 changes: 0 additions & 4 deletions arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
*/

#include "sc7180.dtsi"

ap_ec_spi: &spi6 {};
ap_h1_spi: &spi0 {};

#include "sc7180-trogdor.dtsi"
#include "sc7180-trogdor-ti-sn65dsi86.dtsi"

Expand Down
4 changes: 0 additions & 4 deletions arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
/dts-v1/;

#include "sc7180.dtsi"

ap_ec_spi: &spi6 {};
ap_h1_spi: &spi0 {};

#include "sc7180-trogdor.dtsi"
#include "sc7180-trogdor-ti-sn65dsi86.dtsi"

Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@
};
};

&ap_ec_spi {
ap_ec_spi: &spi6 {
status = "okay";
cros_ec: ec@0 {
compatible = "google,cros-ec-spi";
Expand Down Expand Up @@ -675,7 +675,7 @@
};
};

&ap_h1_spi {
ap_h1_spi: &spi0 {
status = "okay";
cr50: tpm@0 {
compatible = "google,cr50";
Expand Down

0 comments on commit d277cab

Please sign in to comment.