Skip to content

Commit

Permalink
net: qede: propagate extack through qede_flow_spec_validate()
Browse files Browse the repository at this point in the history
Pass extack to qede_flow_spec_validate() when called in
qede_flow_spec_to_rule().

Pass extack to qede_parse_actions().

Not converting qede_flow_spec_validate() to use extack for
errors, as it's only called from qede_flow_spec_to_rule(),
where extack is faked into a DP_NOTICE anyway, so opting to
keep DP_VERBOSE/DP_NOTICE usage.

Only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240508143404.95901-14-ast@fiberby.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Asbjørn Sloth Tønnesen authored and Jakub Kicinski committed May 11, 2024
1 parent eb705d7 commit d2a437e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/net/ethernet/qlogic/qede/qede_filter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1953,7 +1953,8 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, __be16 proto,
static int qede_flow_spec_validate(struct qede_dev *edev,
struct flow_action *flow_action,
struct qede_arfs_tuple *t,
__u32 location)
__u32 location,
struct netlink_ext_ack *extack)
{
int err;

Expand All @@ -1977,7 +1978,7 @@ static int qede_flow_spec_validate(struct qede_dev *edev,
return -EINVAL;
}

err = qede_parse_actions(edev, flow_action, NULL);
err = qede_parse_actions(edev, flow_action, extack);
if (err)
return err;

Expand Down Expand Up @@ -2024,7 +2025,7 @@ static int qede_flow_spec_to_rule(struct qede_dev *edev,

/* Make sure location is valid and filter isn't already set */
err = qede_flow_spec_validate(edev, &flow->rule->action, t,
fs->location);
fs->location, &extack);
err_out:
if (extack._msg)
DP_NOTICE(edev, "%s\n", extack._msg);
Expand Down

0 comments on commit d2a437e

Please sign in to comment.